crteensy Posted November 26, 2015 Report Share Posted November 26, 2015 At https://bitbucket.org/Tectu/ugfx/src/fb ... 1351.c-121the bus is released, post_init_board is called, and the bus is released again. If post_init_board aquires the bus, it should also release it. I would remove the first call to release_bus. What was the reason for two calls to release_bus? Link to comment Share on other sites More sharing options...
inmarket Posted November 26, 2015 Report Share Posted November 26, 2015 No reason. It is an error.I will correct it tomorrow to be consistent with other drivers (which i think is release called before but not after).Thanks for finding it. Link to comment Share on other sites More sharing options...
crteensy Posted November 26, 2015 Author Report Share Posted November 26, 2015 SSD1331: release_bus() called before post_init_board()ILI9341: post_init_board() called before release_bus()Also how mature is the ILI9341 driver? The oldest file has this commit comment: "New ILI9341 driver - not working fully yet (some display issues)" Link to comment Share on other sites More sharing options...
inmarket Posted November 26, 2015 Report Share Posted November 26, 2015 The ILI9341 is used by the Mikromedia STM32 M4 board which is one of my main development boards so last i looked it was working well.Having said that recently I have been using the STM32F746-Discovery board as its driver has been a work in progress with lots of complications but essential for future STM32 processors. There was also some thought to replace some of the hard coded values with an include file but i cant remember how far that got.So, in conclusion yes it dhould definitely work. I will recheck just to make sure later today. Link to comment Share on other sites More sharing options...
Joel Bodenmann Posted November 26, 2015 Report Share Posted November 26, 2015 The ILI9341 is known to work well. I have a couple of products/boards here that use the ILI9341. The only thing that might not be 100% supported are orientations and power modes. However, I have a fully working driver. I will put that into the repository soon next week.~ Tectu Link to comment Share on other sites More sharing options...
inmarket Posted November 27, 2015 Report Share Posted November 27, 2015 I just dug up my board with that controller.Everything works well including orientation support.I don't think power modes are implemented (or if they are they are untested). Link to comment Share on other sites More sharing options...
inmarket Posted November 27, 2015 Report Share Posted November 27, 2015 I have fixed the release_bus() calls for the SSD1331 and the SSD1351 drivers.All others are correct.I was wrong in my thoughts above - the correct place is after the post_init_board() call. Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now