Bug in SSD1289 driver

[samofab]

For 270 orientation fill_area doesn't work. I localized the problem to set_viewport

line 95 in gdisp_lld.c: write_reg(0x44, (((x+cx-1) << 8) & 0xFF00 ) | (y & 0x00FF));

should be

write_reg(0x44, (((y+cy-1) << 8) & 0xFF00 ) | (y & 0x00FF));

[Joel Bodenmann]

Thank you very much for finding and reporting.

I have currently lend my SSD1289 hardware to a friend - I'll digg into this within the following week.

~ Tectu

[Joel Bodenmann]

I finally got my hardware back so I could test it out. You were right, there was a bug. It's fixed.

Thank you very much for finding and reporting!

~ Tectu

[Eddie]

in current trunk, gdisp lcd SSD1289.c semicolon is missing..

line 243:	dma_with_noinc(g, &c, g->p.cx*g->p.cy)

[Joel Bodenmann]

in current trunk, gdisp lcd SSD1289.c semicolon is missing..

Fixed. Thank you very much, we appreciate these bug reports a lot.

One of our major problems is that we can't test every possible case with the settings in the gfxconf.h as they are just too nested.

~ Tectu

[Eddie]

After initial problems, I have a working project for version 2.0 and testing the demo projects. My setup is stm32f4 discovery board, Open407V-D board and 3.2inch 320x240 Touch LCD with SSD1289 and ADS7843. I will report possible bugs.

[Joel Bodenmann]

Thank you very much for your support. From my own experience (mainly as a user), I agree that x.0 releases are always a bit tricky as there are some major restructurings happening

It would be nice if you could contribute a boards/base directory for the Open407V-D to the community.

~ Tectu