Issue(s) in LTDC Driver

[Steffan]

While working with the LTDC I stumbled up on two issues in the LTDC driver:

1.  See https://git.ugfx.io/uGFX/uGFX/src/master/drivers/gdisp/STM32LTDC/gdisp_lld_STM32LTDC.c#L60 the sync field is 8-bit, while it seems it should be 32-bit as the corresponding defines are > 8 bit.
2. "PIXIL_POS" ( see https://git.ugfx.io/uGFX/uGFX/src/master/drivers/gdisp/STM32LTDC/gdisp_lld_STM32LTDC.c#L98 ). Why is it called PIXIL and not PIXEL? Is this on purpose or is this a mistake? The same macro ended up in gdisp_lld_fb24bpp.c and gdisp_lld_framebuffer.c

[Joel Bodenmann]

Thank you very much for bringing this to our attention, we'll have a look at that in the following days.

[inmarket]

2. The spelling of pixel as pixil is a private and historical joke. A pix-el is a picture (pix) element (el). A pixil is then an pix with an ill ie a broken pixel. Thus the spelling of the word pixel as pixil is both an easter egg (hidden treasure) and a comment on the pixels being broken (buggy) hence the joke. The private part refers to a funny incident way back in my early programming history (roughly 35 years ago) that has led me to consistently and intentionally mispell it in my code since then.

Well done on finding it. We will probably leave the spelling as it is as it is internal code only, not something a user would normally play with and it always gives me a chuckle.

[Steffan]

Hah, Ok. I'll never get over this. Im sure of it.

[inmarket]