Question regarding gwinProgressbarDecrement()

[kengineer]

Why does the gwinProgressbarDecrement() function decrement by both the resolution and the minimum? Shouldn't it be one or the other, and if anything I would think we would always decrement by the resolution and cap it at the min.

 

This also will allow the progress bar to fall outside the min range as an additional decrement of the step always occurs no matter what not to mention that if I want to decrement by 1 normally it will always decrement more.

 

void gwinProgressbarDecrement(GHandle gh) {
	#define gsw		((GProgressbarObject *)gh)

	if (gh->vmt != (gwinVMT *)&progressbarVMT)
		return;

	if (gsw->pos > gsw->res)
		gsw->pos -= gsw->min;
	else
		gsw->pos = gsw->min;

	gsw->pos -= gsw->res;

	PBResetDisplayPos(gsw);
	_gwinUpdate(gh);

	#undef gsw
}

 

I would think it should be something more like this:

void gwinProgressbarDecrement(GHandle gh) {
	#define gsw		((GProgressbarObject *)gh)

	if (gh->vmt != (gwinVMT *)&progressbarVMT)
		return;

	if (gsw->pos > gsw->min)
		gsw->pos -= gsw->res;
	else
		gsw->pos = gsw->min;

	PBResetDisplayPos(gsw);
	_gwinUpdate(gh);

	#undef gsw
}

 

 

Please clarify if I'm not understanding the use of this correctly.

[inmarket]

This is now fixed in the repository along with a couple of other bugs found when I reviewed the progressbar code.

[kengineer]

Thanks @inmarket!