Jump to content

Small bug(I think) in gwin_frame.c


TriZet

Recommended Posts

Hello!

Many thanks for your work! It's amaizing project.

Now to the work ))

I have played with uGFX and seen what top menu buttons(maximize, minimize, close) respond for touch on all Y space from top to bottom of frame.

I found this place(line 57 in gwin_frame.c) and think what something like this must be ))

Then bug is fixed.

	static void mouseDown(GWidgetObject *gw, coord_t x, coord_t y) {
coord_t pos;

// We must be clicking on the frame button area to be of interest
//if (y < BUTTON_T && y >= BUTTON_T+BUTTON_Y) OLD CODE !!
if (y < BUTTON_T || y >= BUTTON_T+BUTTON_Y)
return;

pos = gw->g.width - (BORDER_R+BUTTON_X);
if ((gw->g.flags & GWIN_FRAME_CLOSE_BTN)) {
if (x >= pos && x < pos+BUTTON_X) {

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
×
×
  • Create New...